Add a .queue_name method to CallQueue... #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...we can't use .name, because it conflicts with logger or celluloid or something.
...this way, if a CallQueue instance crashes, and gets restarted by it's supervisor, #get_queue will return the restarted queue (or at least a usable proxy to it), instead of returning a reference to a dead, crashed, and burned queue that's dead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.name, because it conflicts with logger or celluloid orsomething.
.workmethod return the celluloid actor doing the work, so that the queue instance is returned here and makes it into the@queueshash.